Fix snaps-controllers and snaps-execution-environments tests#1835
Merged
Mrtenz merged 4 commits intofb/bump-json-rpc-engine-et-allfrom Oct 11, 2023
Merged
Conversation
Mrtenz
changed the title
snaps-controllers and snaps-execution-environments tests
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fb/bump-json-rpc-engine-et-all #1835 +/- ##
=================================================================
Coverage ? 95.96%
=================================================================
Files ? 241
Lines ? 5602
Branches ? 885
=================================================================
Hits ? 5376
Misses ? 226
Partials ? 0 ☔ View full report in Codecov by Sentry. |
packages/snaps-controllers/src/services/node/NodeThreadExecutionService.test.ts
Show resolved
Hide resolved
packages/snaps-controllers/src/services/node/NodeThreadExecutionService.test.ts
Show resolved
Hide resolved
packages/snaps-controllers/src/services/node/NodeProcessExecutionService.test.ts
Show resolved
Hide resolved
packages/snaps-controllers/src/services/node/NodeProcessExecutionService.test.ts
Show resolved
Hide resolved
FrederikBolding
approved these changes
Oct 11, 2023
FrederikBolding
pushed a commit
that referenced
this pull request
Oct 11, 2023
This fixes the Snaps controllers and execution environments tests on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Snaps controllers and execution environments tests on #1818.